-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use Pota #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psimk
requested review from
ThaNarie,
jspolancor,
larsvanbraam,
ThijsTyZ,
jesse-mm,
pigeonfresh and
jyggiz
December 3, 2021 10:43
…d the issue (peer dependency)
Found an issue with the template rendering and HMR;
|
@ThaNarie |
…are both set to mode: development
…erver for built mocks
This was referenced Jan 6, 2022
…ks to the main build's output static directory
ThaNarie
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was initially tasked with solving the performance and stability issues with the existing skeleton, however as we are currently transitioning all of Media.Monk's skeletons to Pota, I figured that I can also transition the
muban-skeleton
right away.Why Pota?
From internal discussions I discovered that internally we will require at least one more Muban Skeleton, so using Pota allows the new
muban-skeleton
to be extensible. Additionally, there is a number of other benefits introduced by Pota:webpack-skeleton
muban-skeleton
does not have to worry about updating or maintaining the base webpack configuration and we can focus on muban-specific configuration.@pota/create
@pota/cli
, which allows defining custom arg options (no more env variables!)What are the changes?
yarn
and usingnpm
is now requiredAs we are now extending the
webpack-skeleton
, we are also inheriting its configuration. These are the most notable files/configuration options that are now inherited:.browserslistrc
->package.json["browserslist"]
tsconfig.json
babel.config.js
-> handled bywebpack-skeleton
's webpack configuration@pota/create
from `webpack-skeleton:dev
format
(used to beprettify
)typecheck
(use to becheck-types
)build:preview
has been removed in favor ofnpm run build -- --preview
(pota build --preview
)analyze
has been removed in favor ofnpm run build -- --analyze
(pota build --analyze
)The locations of static assets have also been changed:
/static
folder (previous/src/public/static
)..html
) are now located in/src/pages/public
(previoussrc/pages/static
&/scripts/devserver/index.html
).For consistency with other Pota skeletons the entry files have been renamed to
main.ts
. Additionally, the pages (preview) build's/src/server-bundle.ts
has been moved to/src/pages/main.ts
.The general stability 📑 and performance 🏎️ is also greatly improved as we are now letting
webpack
handle page (preview) generation.How can I test this out?
You can already setup a project from the new skeleton using
@pota/create
:If you want to make some changes to the skeleton and test it out locally:
Okay, when can we merge this?
The transition is not fully complete and I will continue updating this PR, here are the remaining todo's:
/patches
into their respective packages@muban/storybook
)@storybook/builder-webpack5
, requires Core: Renamegenerated-stories-entry
tocjs
extension so require works storybookjs/storybook#16727)@storybook/core-server
)monck
supportdeploy
command (needs to be done inwebpack-skeleton
)classnames
withclsx